nfc_tag_14a_event_callback(): Fixes wrong reported length when sniffing#449
Open
DidierA wants to merge 3 commits into
Open
nfc_tag_14a_event_callback(): Fixes wrong reported length when sniffing#449DidierA wants to merge 3 commits into
DidierA wants to merge 3 commits into
Conversation
…h failed when there was more than 7 parity bits. Fixes RfidResearchGroup#444
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit 3cba53cFirmwareClient |
DidierA
changed the title
3 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
nfc_tag_14a_event_callback(), when sniffing, a computation was made to tell which number of parity bits is in the array, and provide the number of bits tom_tx_sniff_cb(). However this is not necessary, sinceamtalready contains the number of bits, and the computation is wrong: it extracts the 3 least significant bits ofamtto get how many parity bits there are, but there can be more than 7 parity bits.This fixes issue #444 .