update Rex::Hardware::VirtInfo to work in a cross platform manner#1599
Closed
VVelox wants to merge 6 commits intoRexOps:masterfrom
Closed
update Rex::Hardware::VirtInfo to work in a cross platform manner#1599VVelox wants to merge 6 commits intoRexOps:masterfrom
VVelox wants to merge 6 commits intoRexOps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously Rex::Hardware::VirtInfo made heavy use of linuxisms and was not cross platform friendly.
This update uses /proc on Linux and dmidecode else where. For modules on FreeBSD kldstat is used. Unforftunately not aware of a good cross platform equivalent of the self_status check.
Also kvm module is now only looked for on Linux with vmm(bhyve) being looked for on FreeBSD.
Tested as working on FreeBSD bhyve host and guest as well as Linux kvm host.
This PR is a proposal to fix # by .
Checklist