Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing params for better changelogs when bumping #513

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Adds missing params for better changelogs when bumping #513

merged 1 commit into from
Jan 5, 2023

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jan 5, 2023

@vegaro vegaro requested a review from tonidero January 5, 2023 10:06
@vegaro vegaro added the ci label Jan 5, 2023
tonidero
tonidero approved these changes Jan 5, 2023
View reviewed changes
fastlane/Fastfile Outdated
)
update_hybrids_versions_file(
versions_file_path: './VERSIONS.md',
versions_file_path: versions_path,
new_sdk_version: current_version_number,
hybrid_common_version: get_phc_version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, you can now use phc_version

@vegaro vegaro merged commit e22474e into main Jan 5, 2023
@vegaro vegaro deleted the update-params branch January 5, 2023 12:09
@RCGitBot RCGitBot mentioned this pull request Jan 9, 2023
Merged
@vegaro vegaro added pr:other A code change that improves performance and removed pr:ci labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
pr:other A code change that improves performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vegaro @tonidero