Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PurchasesEntitlementInfo type doesn't reflect all properties from actual data #708

Open
yaroslavnikiforov opened this issue Aug 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@yaroslavnikiforov
Copy link

The following properties are not present in the PurchasesEntitlementInfo type, and you get a TypeScript error when trying to access them:

expirationDateMillis
unsubscribeDetectedAtMillis
latestPurchaseDateMillis
ownershipType
billingIssueDetectedAtMillis
originalPurchaseDateMillis
  1. Environment
    1. Platform:
    2. SDK version: 6.6.0
    3. OS version:
    4. Xcode/Android Studio version:
    5. React Native version:
    6. SDK installation (CocoaPods + version or manual):
    7. How widespread is the issue. Percentage of devices affected.
  2. Debug logs that reproduce the issue
  3. Steps to reproduce, with a description of expected vs. actual behavior
  4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

Additional context
Add any other context about the problem here.

@yaroslavnikiforov yaroslavnikiforov added the bug Something isn't working label Aug 8, 2023
@RCGitBot
Copy link
Contributor

RCGitBot commented Aug 8, 2023

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@MarkVillacampa
Copy link
Member

Thank you for the feedback @yaroslavnikiforov! We will add those fields to the Typescript interface.

tonidero added a commit to RevenueCat/purchases-hybrid-common that referenced this issue Aug 8, 2023
This PR:
- Make `metadata` use correct type.
RevenueCat/react-native-purchases#700
- Add missing properties on `PurchasesEntitlementInfo` that are provided
by PHC layer.
RevenueCat/react-native-purchases#708

Nothing is currently using the typescript package, but the plan is to
move to use it in the RNP repo and the future capacitor plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants