fix(checkpoints): fix audience loading and missing-dimension evaluation - #7602
Draft
rickvdl wants to merge 6 commits into
Draft
fix(checkpoints): fix audience loading and missing-dimension evaluation#7602rickvdl wants to merge 6 commits into
rickvdl wants to merge 6 commits into
Conversation
4 builds increased size
RevenueCat 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 88.3 kB |
| Code Signature | ⬆️ 5.9 kB |
| RevenueCat.CustomerInfoManager.CustomerInfoManager | ⬆️ 2.9 kB |
| DYLD.Exports | ⬆️ 1.7 kB |
| Strings.Unmapped | ⬆️ 1.5 kB |
View Treemap
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source
⚖️ Compare build
📦 Install build
⏱️ Analyze build performance
Total install size change: ⬆️ 73.4 kB (0.51%)
Total download size change: ⬆️ 31.1 kB (0.63%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 📝 RevenueCat.CustomerInfoDimensionProvider.values(for,at) | ⬆️ 7.2 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.entitlements(from) | ⬆️ 6.1 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.purchases(from,at) | ⬆️ 3.3 kB |
| Swift.Sequence.reduce(into) | ⬆️ 3.2 kB |
| Swift.UnsafeMutableBufferPointer._stableSortImpl(by) | ⬆️ 3.0 kB |
View Treemap
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods
⚖️ Compare build
📦 Install build
⏱️ Analyze build performance
Total install size change: ⬆️ 131.9 kB (0.42%)
Total download size change: ⬆️ 32.5 kB (0.45%)
Largest size changes
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 42.8 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.values(for,at) | ⬆️ 7.2 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.entitlements(from) | ⬆️ 6.1 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.purchases(from,at) | ⬆️ 4.3 kB |
| Swift.Sequence.reduce(into) | ⬆️ 3.6 kB |
View Treemap
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm
⚖️ Compare build
📦 Install build
⏱️ Analyze build performance
Total install size change: ⬆️ 68.9 kB (0.55%)
Total download size change: ⬆️ 30.0 kB (0.61%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 📝 RevenueCat.CustomerInfoDimensionProvider.values(for,at) | ⬆️ 7.2 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.entitlements(from) | ⬆️ 6.1 kB |
| 📝 RevenueCat.CustomerInfoDimensionProvider.purchases(from,at) | ⬆️ 3.3 kB |
| Swift.Sequence.reduce(into) | ⬆️ 3.2 kB |
| Swift.UnsafeMutableBufferPointer._stableSortImpl(by) | ⬆️ 3.0 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
❌ CI Job Failed —
|
Member
Author
|
@RCGitBot please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces two small improvements
LocalRulesEvaluatorto no longer return.noAction(.configurationUnavailable)when a variable used in the rule is missing, but rather.noAction(.noMatch)instead as described in the RFC.