Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [AppUpdateWarningView] Tweak buttons bottom alignment and padding #4807

Merged
merged 4 commits into from
Feb 21, 2025
Merged

fix: [AppUpdateWarningView] Tweak buttons bottom alignment and padding #4807

merged 4 commits into from
Feb 21, 2025

Conversation

facumenzella
Copy link
Contributor

Motivation

While working on some padding, I went one step further and aligned the buttons to the bottom.

@facumenzella facumenzella requested a review from a team February 21, 2025 10:05
ajpallares
ajpallares approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better like this 👍

tonidero
tonidero approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Just a couple questions since I'm not too familiarized with SwiftUI :)

@facumenzella facumenzella enabled auto-merge (squash) February 21, 2025 12:28
JayShortway
JayShortway approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@facumenzella facumenzella merged commit ed20901 into main Feb 21, 2025
10 checks passed
@facumenzella facumenzella deleted the feat/update-buttons branch February 21, 2025 12:53
@RCGitBot RCGitBot mentioned this pull request Feb 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

@ajpallares ajpallares ajpallares approved these changes

@JayShortway JayShortway JayShortway approved these changes

Assignees
No one assigned
Labels
feat:Customer Center pr:fix A bug fix pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@facumenzella @tonidero @ajpallares @JayShortway