Better logs for promotional offer view #4336
Conversation
vegaro
commented
Oct 2, 2024
•
vegaro
commented
- Improved debug logs for promotional offer view
- Updated SKConfig file to add a promotional offer
- Updated SKConfig file storefront to en_US
| return .failure(CustomerCenterError.couldNotFindSubscriptionInformation) | ||
| } | ||
|
|
||
| guard let discount = subscribedProduct.discounts.first(where: { | ||
| $0.offerIdentifier == promoOfferDetails.iosOfferId | ||
| }) else { | ||
| Logger.warning(Strings.could_not_offer_for_active_subscriptions) | ||
| Logger.warning(Strings.could_not_offer_for_active_subscriptions(promoOfferDetails.iosOfferId, productIdentifier)) |
There was a problem hiding this comment.
Hmm I'm not sure if these should be warnings or debug... seems like a case that may happen somewhat often if the customer is not eligible by apple? Not a strong opinion though
There was a problem hiding this comment.
seems like a case that may happen somewhat often if the customer is not eligible by apple?
That will actually fail later, this will fail if the active product's discounts don't match with the promotional offers in the Customer Center config.
I actually think it could be a debug yes, I will change it
| "_locale" : "es_ES", | ||
| "_storefront" : "ESP", | ||
| "_locale" : "en_US", | ||
| "_storefront" : "USA", |
There was a problem hiding this comment.
Just checking but any reason to change the storefront/locale? I'm ok with the change though.
There was a problem hiding this comment.
this is intentional, should've mention it in the description. This was causing the paywalls tester to have a mix of Spanish (subscription name) and English and figured we didn't want that.
