-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases.shared.purchase(product: product) completion is not called #2415
Comments
👀 SDKONCALL-260 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Thanks! Could you share a bit more code, how you're configuring the SDK and the code around the purchase call? |
SDK:
Making purchase:
|
|
Also it would be helpful if you can let us know if you're able to reproduce this with StoreKit 2 enabled so we can eliminate one variable and isolate where the bug might be. |
I removed |
I tried to use StoreKit2 and it works... the |
Also when I setup Purchases like this:
Completion block is called... I leave the |
Just wanted to isolate this is SK1 only, that's already helpful. Can you configure the SDK with log level verbose?
That might have extra information to help us figure out the problem. Thanks a lot! |
Will it work for people with |
It won't. Can you share those same verbose log but with StoreKit 2 disabled? 🙏🏻 I'm looking at the code and I believe it's somewhere in |
|
I'm looking into this. The root of the problem is that StoreKit is notifying the SDK that the transaction was removed before finishing the transaction:
Which is not normal behavior. It makes sense that that this does not reproduce in production, and not very surprised it's happening on sandbox. But we'll obviously need to figure out the reason and/or work around it. Thanks again for the very detailed report, we'll have a fix soon 👌🏻 |
Will be a new version available soon (in 2 days)? Is it safe to release the version now to the AppStore? |
Now that we know it's a StoreKit issue, and if you're not able to reproduce on the App Store version, I'd say it's safe. |
@DavidKadlcek is this happening with or without It would also be helpful if you can click "Debug -> StoreKit -> Manage Transactions" and send us the list of transactions there after you reproduce: |
I sent you physical device. Also I tried it in simulator and I saw transaction completed inside the |
I wonder if this is an iOS 16.3 regression? |
I tried to run it on the simulator with |
…llbacks to notify This would make issues like #2415 easier to debug.
@DavidKadlcek apologies if I already asked but I couldn't find your answer: are you able to reproduce this with a brand new sandbox account? Make sure to also remove the user / anonymous user from the RevenueCat dashboard as well to ensure a clean state. |
@NachoSoto yes, it is happening on the newly created sandbox account too |
@NachoSoto Any progress? |
We shipped an update (4.18.0) with a couple of new debug logs to help debug this. Would you mind trying to reproduce it with it and sending us the new logs? 🙏 |
|
@NachoSoto any update? |
ironically this same issue only started with me when I updated RC to 4.18.0 |
What version did you update from? |
Hello, @NachoSoto |
I've dug into your logs and our implementation, and the only explanation to this happening is that something is calling Additionally, when you're testing with |
… calls Just a small addition that might help debug #2415.
Posting this for reference:
And this is what you're getting:
When we try to finish the transaction, |
I had the same issue a few months ago when I updated my app. My workaround was to go back to 4.16.0 |
@NachoSoto There is no way, that I call |
Ir would be really helpful if you could put a breakpoint on |
Same issue on last version of sdk. On 4.16.0 works fine. |
@emissarman thanks for letting us know. |
@DavidKadlcek and I just had a call and looked through the issue together. We found out that the root of the problem was https://github.com/bizz84/SwiftyStoreKit and how it was set up. @Tibbs @emissarman can you let us know if you're also using that framework or other Suggested solutions:
I'll mark this bug as completed, but let us know if you still need help with this. |
This issue has been automatically locked due to no recent activity after it was closed. Please open a new issue for related reports. |
Describe the bug
A clear and concise description of what the bug is. The more detail you can provide the faster our team will be able to triage and resolve the issue. Do not remove any of the steps from the template below. If a step is not applicable to your issue, please leave that step empty.
The problem is that
Purchases.shared.purchase(product: product) { // This is not called }
completion is not called when I purchase the product. In the console it is showing[Purchases] - INFO: 💰 Finishing transaction '2000000313661251' for product 'david.kadlcek.GuessWho.annualAccess'
(debug log). I try it on the physical device from Xcode and Testflight, and also on the simulator with ConfigurationStoreKit. (Same problem). UI is not frozen. I think that the subscription on the latest version of the app store is working.useStoreKit2IfEnabled(false)
) (Y/N): N (Not using StoreKit2)Purchases.shared.purchase
completion handler is not calledAdditional context
No additional context
The text was updated successfully, but these errors were encountered: