-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 1.3.0 #96
release 1.3.0 #96
Conversation
added new methods for attribution v2 and deprecated old ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't notice about nonSubscriptionTransactions
on the previous review
lib/transaction.dart
Outdated
@@ -0,0 +1,24 @@ | |||
class Transaction { | |||
/// RevenueCat Id associated to the transaction. | |||
final String revenuecatId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized the c is not capitalized in the Android and iOS class, and that the d is lowercase in Id
🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm capitalizing the C, but the d in ID
I'm not updating right now because it should match the original iOS code - once we update it in purchases-ios
, we can update it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, it's a little more problematic - it's capitalized here:
https://github.com/RevenueCat/purchases-hybrid-common/blob/develop/ios/PurchasesHybridCommon/PurchasesHybridCommon/RCTransaction%2BHybridAdditions.m#L17
and not here:
https://github.com/RevenueCat/purchases-hybrid-common/blob/develop/android/src/main/java/com/revenuecat/purchases/common/mappers/TransactionMapper.kt#L7
so we'll need another patch release to fix it, otherwise mappers won't work.
I'll take care of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, tested and working with common 1.4.2 RevenueCat/purchases-hybrid-common#55
This PR will need to bump the version number once the hybrid-common release is out, though. adding a hold until then.
@vegaro this is ready for another pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge when those docs are fixed
* bumped purchases-hybrid-common to 1.3.1 * bumped common version to 1.4.0 * added empty swift file so that swift code compiles correctly * ignored .last_build_id * updated deployment target version to 9.0. added new methods for attribution v2 and deprecated old ones * added new methods for attribution v2 to flutter plugin interface * added new methods to the flutter dart interface * added deprecation warning in dart * fixeed param names typo for iOS, added new methods for Android * updated purchases-hybrid-common version for Android * bumped version number and added changelog * reverted accidental changes in podfile and main.dart * removed deprecated call to addAttributionData in the example app * fix typo in purchases_flutter.dart * fixed typo in build.gradle, updated version of gradle build * fixed missing semicolons * updated calls to common code in PurchasesFlutterPlugin * updated version of purchases-hybrid-common * updated podfile to use purchases-hybrid-common 1.4.1 * fix typo in fbAnonymousID * fix docs from PR comments * added nonSubscriptionTransactions * fixed mapping of transactions * updates to documentation for collectDeviceIdentifiers * bumped purchases-hybrid-common to 1.4.2 * fixes docs for non-subscription transactions * ran flutter format
1.3.0
addAttribution
in favor ofsetAdjustId
,setAppsflyerId
,setFbAnonymousId
,setMparticleId
.setOnesignalId
setMediaSource
,setCampaign
,setAdGroup
,setAd
,setKeyword
,setCreative
, andcollectDeviceIdentifiers
Fixes 404 marking attributes as synced purchases-android#184
purchases-hybrid-common
to 1.4.2 Changelog herepurchases-ios
to 3.7.1 Changelog herepurchases-android
to 3.5.0 Changelog here