Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.3.0 #96

Merged
merged 27 commits into from
Sep 23, 2020
Merged

release 1.3.0 #96

merged 27 commits into from
Sep 23, 2020

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Sep 19, 2020

1.3.0

@aboedo aboedo self-assigned this Sep 19, 2020
@aboedo aboedo marked this pull request as draft September 19, 2020 00:05
@aboedo aboedo changed the title bump common to 1.4.0 bump common to 1.4.1 Sep 21, 2020
@aboedo aboedo changed the title bump common to 1.4.1 release 1.3.0 Sep 21, 2020
@aboedo aboedo marked this pull request as ready for review September 21, 2020 18:57
@aboedo aboedo added the HOLD label Sep 21, 2020
@aboedo aboedo marked this pull request as draft September 21, 2020 18:58
@aboedo aboedo removed the HOLD label Sep 21, 2020
@aboedo aboedo requested a review from vegaro September 21, 2020 19:56
@aboedo aboedo marked this pull request as ready for review September 21, 2020 19:56
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vegaro
vegaro previously approved these changes Sep 21, 2020
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice about nonSubscriptionTransactions on the previous review

@@ -0,0 +1,24 @@
class Transaction {
/// RevenueCat Id associated to the transaction.
final String revenuecatId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized the c is not capitalized in the Android and iOS class, and that the d is lowercase in Id 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm capitalizing the C, but the d in ID I'm not updating right now because it should match the original iOS code - once we update it in purchases-ios, we can update it here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, tested and working with common 1.4.2 RevenueCat/purchases-hybrid-common#55

This PR will need to bump the version number once the hybrid-common release is out, though. adding a hold until then.

@vegaro vegaro dismissed their stale review September 22, 2020 00:54

realized a minor change

@aboedo aboedo added the HOLD label Sep 22, 2020
@aboedo aboedo requested a review from vegaro September 22, 2020 14:40
@aboedo aboedo removed the HOLD label Sep 23, 2020
@aboedo
Copy link
Member Author

aboedo commented Sep 23, 2020

@vegaro this is ready for another pass

Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when those docs are fixed

@aboedo aboedo merged commit 3fdfa13 into develop Sep 23, 2020
@aboedo aboedo deleted the feature/bump_common branch September 23, 2020 17:08
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
* bumped purchases-hybrid-common to 1.3.1

* bumped common version to 1.4.0

* added empty swift file so that swift code compiles correctly

* ignored .last_build_id

* updated deployment target version to 9.0.
added new methods for attribution v2 and deprecated old ones

* added new methods for attribution v2 to flutter plugin interface

* added new methods to the flutter dart interface

* added deprecation warning in dart

* fixeed param names typo for iOS, added new methods for Android

* updated purchases-hybrid-common version for Android

* bumped version number and added changelog

* reverted accidental changes in podfile and main.dart

* removed deprecated call to addAttributionData in the example app

* fix typo in purchases_flutter.dart

* fixed typo in build.gradle, updated version of gradle build

* fixed missing semicolons

* updated calls to common code in PurchasesFlutterPlugin

* updated version of purchases-hybrid-common

* updated podfile to use purchases-hybrid-common 1.4.1

* fix typo in fbAnonymousID

* fix docs from PR comments

* added nonSubscriptionTransactions

* fixed mapping of transactions

* updates to documentation for collectDeviceIdentifiers

* bumped purchases-hybrid-common to 1.4.2

* fixes docs for non-subscription transactions

* ran flutter format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants