Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 3.9.4 release #326

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Prep for 3.9.4 release #326

merged 6 commits into from
Feb 18, 2022

Conversation

beylmk
Copy link
Contributor

@beylmk beylmk commented Feb 15, 2022

No description provided.

@@ -25,7 +25,7 @@ apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 30
compileSdkVersion 31
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the default when creating a new Flutter plugin project so I would prefer not updating this since it will require devs to install version 31 of the SDK. Do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was testing for CI but should've only done the example apps...

@beylmk beylmk force-pushed the release/3.9.4 branch 4 times, most recently from 3358746 to 53e96eb Compare February 16, 2022 22:48
@beylmk beylmk requested a review from a team February 17, 2022 17:02
@aboedo
Copy link
Member

aboedo commented Feb 18, 2022

@vegaro @beylmk anything else we need to do here?

Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting on the emulator thing to get fixed. Looks like it's fixed now so it should be good to go


- Fix missing IntroductoryPrice export (https://github.com/RevenueCat/purchases-flutter/pull/310)
- Add back IntroductoryPrice fields that were accidentally removed without a major release (https://github.com/RevenueCat/purchases-flutter/pull/319)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe indicating the fields that are added back would be a good idea

@beylmk beylmk merged commit 736404d into main Feb 18, 2022
@beylmk beylmk deleted the release/3.9.4 branch February 18, 2022 17:02
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants