Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates versions to match the ones when creating a new plugin #285

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Dec 27, 2021

When investigating #284 I realized that we are compiling using Android 28, whereas when creating a new plugin using the Flutter tool, the default is 30. I basically run the following using the latest stable Flutter 2.8.1:

flutter create --org com.example --template=plugin --platforms=android -a java hello

And updated whatever was different.

@vegaro vegaro changed the title updates versions to match new plugin creation Updates versions to match the ones when creating a new plugin Dec 27, 2021
@vegaro vegaro requested a review from a team December 27, 2021 13:12
@vegaro
Copy link
Contributor Author

vegaro commented Dec 27, 2021

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💪 (once rebased to fix tests)

@vegaro vegaro merged commit 8d6df73 into main Dec 28, 2021
@vegaro vegaro deleted the match-new-plugin-create branch December 28, 2021 13:48
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
…eCat#285)

* updates versions to match new plugin creation

* update sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants