Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.6.0 #272

Merged
merged 11 commits into from
Nov 12, 2021
Merged

Release/3.6.0 #272

merged 11 commits into from
Nov 12, 2021

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Nov 10, 2021

3.6.0

@aboedo aboedo self-assigned this Nov 10, 2021
@aboedo aboedo marked this pull request as ready for review November 10, 2021 19:07
@aboedo aboedo requested a review from a team November 10, 2021 19:07
@aboedo
Copy link
Member Author

aboedo commented Nov 12, 2021

@RevenueCat/sdk bump

/// Subscriber attribute associated with the Airship Channel Id for the user
/// Required for the RevenueCat Airship integration
///
/// [airshipChannelID] Empty String or null will delete the subscriber attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the note about nil/empty strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you clarify? this docstring does note that empty string or null will delete the subs attribute

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh um either friday brain or i was looking at the wrong commit, sorry

Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aboedo aboedo merged commit 4a1a12f into main Nov 12, 2021
@aboedo aboedo deleted the release/3.6.0 branch November 12, 2021 19:26
Jethro87 pushed a commit to Jethro87/purchases-flutter that referenced this pull request Jan 4, 2025
* updated purchases-hybrid-common version for iOS

* added `setAirshipChannelID` method

* added missing wiring for iOS

* added wiring for Android

* update ruby dependencies

* bumped version number to 3.6.0

* cleaned up formatting

* updated PR number

* updated pods

* added step to setup_circle_ci + auto-update fastlane

* updated VERSIONS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants