Add BC7 version of library when deploying #1542
Conversation
| ) | ||
|
|
||
| # Update CHANGELOG.md to include BC7 version | ||
| update_changelog_with_bc7_version(changelog_path, current_version_number) |
There was a problem hiding this comment.
Have to do this because pub.dev validates that the version number appears in the changelog. This seemed the simpler way to bypass this validation.
| # Temporarily commit changes to satisfy git clean check | ||
| Dir.chdir('..') do | ||
| sh('git', 'add', 'pubspec.yaml', 'android/build.gradle') | ||
| sh('git', 'commit', '-m', '[TEMPORARY] BC7 modifications for publishing') |
There was a problem hiding this comment.
I need to commit the files with changes, otherwise it will fail pub.dev validation. This should be fine during CI, since we won't be pushing this commit. But we reset the changes at the end anyway... It might not be undone if the flutter pub publish command fails for any reason though, but this should be fine when run on CI as I mentioned.
|
Keeping this as draft until the PHC part is merged, but this is ready for review @RevenueCat/sdk |
| end | ||
|
|
||
| # Dry run | ||
| Dir.chdir('..') do |
There was a problem hiding this comment.
I was just thinking it might be nice to be able to reuse existing code a bit more, for example calling the regular release lane here. But I also realized this would often require passing some new parameters and would probably not be worth the effort. Since it should be temporary in the grand scheme of things anyways I think this approach makes sense as-is.
There was a problem hiding this comment.
Yeah... I think we could try to refactor it to avoid repeating code, but as you said, this will go away in a few months at most, so might be easier to clean it up later if we keep it split.
With this, when we deploy a new version of the library, we will also deploy versions with a
+bc7metadata using the bc7 version of the Android native SDK.Depends on RevenueCat/purchases-hybrid-common#1371