Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.3 #128

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Release 1.4.3 #128

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1587508
fixed xcconfig files mapping
aboedo Nov 4, 2020
4ce3660
explicitly added s.framework = 'Purchases' so cocoapods links the Pur…
aboedo Nov 4, 2020
fe4b10f
bumped version number to 1.4.3
aboedo Nov 4, 2020
ee1eb9e
moved from framework to ldflag
aboedo Nov 4, 2020
463c898
updated changelog
aboedo Nov 4, 2020
da45c42
clean up pod_target_xcconfig
aboedo Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clean up pod_target_xcconfig
  • Loading branch information
@aboedo
aboedo committed Nov 4, 2020
commit da45c42a52b896837349620d4116c121f6b183b4
6 changes: 5 additions & 1 deletion ios/purchases_flutter.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ Pod::Spec.new do |s|
s.swift_version = '5.0'

# Flutter.framework does not contain a i386 slice.
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386', 'OTHER_LDFLAGS' => '$(inherited) -framework Purchases' }
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'i386',
'OTHER_LDFLAGS' => '-framework Purchases'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is the actual fix. it adds a missing linker flag that links the Purchases framework.
I'm not sure why this flag isn't added automatically, I'm still figuring that out. But it did fix the linker issues on the test project I'm using

}

end