Active EntitlementInfo's willRenew property is set to false for lifetime access - contradicting documentation

[AndrasTimar]

• I have updated Purchases SDK to the latest version
• I have read the Contribution Guidelines
• I have searched the Community
• I have read docs.revenuecat.com
• I have searched for existing Github issues

Describe the bug
The willRenew property of my active lifetime entitlementInfo object is set to false, but the documentation states the following:

  /// True if the underlying subscription is set to renew at the end of
  /// the billing period (expirationDate). Will always be True if entitlement
  /// is for lifetime access.
  @JsonKey(name: 'willRenew')
  bool get willRenew => throw _privateConstructorUsedError;

It is a minor issue which can be easily handled on the client side, I just thought I'd let you know.

1. Environment
   Doctor summary (to see all details, run flutter doctor -v):
   [✓] Flutter (Channel stable, 2.10.5, on macOS 12.3.1 21E258 darwin-arm, locale en-HU)
   [!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
   ✗ cmdline-tools component is missing
   Run path/to/sdkmanager --install "cmdline-tools;latest"
   See https://developer.android.com/studio/command-line for more details.
   ✗ Android license status unknown.
   Run flutter doctor --android-licenses to accept the SDK licenses.
   See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
   [✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
   [✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google
   Chrome.app/Contents/MacOS/Google Chrome)
   ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
   [✓] Android Studio (version 2021.1)
   [✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
   [✓] Connected device (2 available)
   [✓] HTTP Host Availability
2. Steps to reproduce, with a description of expected vs. actual behavior
   Give a RevenueCat promotional lifetime access to a user in the RevenueCat console, and check the user's active entitlement.
3. Other information
   Tested on Android device and emulator.

[aboedo]

Thanks for calling this out @AndrasTimar! We'll get this fixed

[stale]

This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs. Please reach out if you have additional information to help us investigate further!

[joshdholtz]

@AndrasTimar Thanks for pointing this out! It turns out that comment was super outdated on this SDK and a bunch of others. This method will return false for lifetime purchases. The behavior has been around for a while and is the intended behavior 😊

Hope this helps and thanks again! ❤️