Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update willRenew comment - will be false for lifetime #349

Merged
merged 1 commit into from
May 20, 2022
Merged

Update willRenew comment - will be false for lifetime #349

merged 1 commit into from
May 20, 2022

Conversation

joshdholtz
Copy link
Member

Motivation

Inspired by RevenueCat/purchases-flutter#361

Description

The comment for entitlement's willRenew was wrong. Lifteime purchases will return false

@joshdholtz joshdholtz requested a review from a team May 13, 2022 02:23
NachoSoto
NachoSoto approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed this was the accepted behavior so :shipit:

@joshdholtz joshdholtz merged commit 036d832 into main May 20, 2022
@joshdholtz joshdholtz deleted the willRenew-update-comment-for-lifetime-will-be-false branch May 20, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NachoSoto NachoSoto NachoSoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshdholtz @NachoSoto