Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround bug in android 4 for JSON objects with List<String> #942

Merged
merged 14 commits into from
May 19, 2023
Merged

Workaround bug in android 4 for JSON objects with List<String> #942

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
977db1e
introduces a workaround for a bug in android 4 where a list of string…
aboedo Apr 4, 2023
5e58860
extracted relevant logic to a MapConverter class
aboedo Apr 6, 2023
e10882d
added tests
aboedo Apr 6, 2023
1bbb188
added docstrings
aboedo Apr 6, 2023
110ccff
removed useless comment
aboedo Apr 6, 2023
5ebcc69
cleanup and fixed mocking
aboedo Apr 6, 2023
394eefa
update test naming for consistency
aboedo Apr 6, 2023
596b296
clear up test name
aboedo Apr 6, 2023
7ab958e
clarified variable names
aboedo Apr 6, 2023
4a58388
fix bad rename
aboedo Apr 6, 2023
b3ca3d0
updated types and behavior to match previous behavior for null body
aboedo Apr 6, 2023
83cc5c0
some clean up from PR comments
aboedo Apr 11, 2023
c2a7709
updated test case to include an actual nested array
aboedo Apr 11, 2023
5eea593
removed unused imports
aboedo Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bad rename
  • Loading branch information
@aboedo
aboedo committed Apr 12, 2023
commit 4a58388f7b586d92c79dc1a21580d4c4459fe8a5
2 changes: 1 addition & 1 deletion common/src/test/java/com/revenuecat/purchases/common/networking/MapConverterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class MapConverterTest {
} returns JSONObject(mapOf("product_ids" to incorrectJsonArrayString))

val resultJson = mapConverterMock.convertToJSON(mapContainingInputMap)
val resultArrayString = resultJson.optJSONObject("root")?.optJSONArray("nested")
val resultArrayString = resultJson.optJSONObject("subscriber_info")?.optJSONArray("product_ids")

assertEquals(correctedJSONArray, resultArrayString)
}
Expand Down