Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 5.2.1 #563

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Release: 5.2.1 #563

merged 4 commits into from
Jul 13, 2022

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jul 13, 2022

Changes from 5.2.1

  • Updates the unityIAP build flavor for compatibility with Unity IAP >= v3.1.0 for observer mode.

Changes from 5.2.0

API Updates

Other

Full Changelog

@aboedo aboedo requested a review from a team July 13, 2022 14:59
@aboedo aboedo self-assigned this Jul 13, 2022
CHANGELOG.md Outdated

* Updates the `unityIAP` build flavor for compatibility with Unity IAP >= v3.1.0 for observer mode.

## Changes from 5.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... this was intentional, though, since I didn't want to overshadow the changes from 5.2.0 because it was released just hours ago. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand. This is the same as the changelog of 5.2.0, which is already in lines 34-60

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good point. My thought was more for maybe the actual github release, it doesn't really make sense to have it here too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see. In any case, I would stick in the releases page to mention just the actual changes of each release. It might seem like 5.2.1 overshadows 5.2.0 at this moment because they were both released within the last hours, which will maybe make someone to miss 5.2.0, but when coming back to the releases page in the future, that effect will disappear and they will just look like two different releases. Do I make sense lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do make sense, and I agree! updated

@aboedo aboedo merged commit d00b872 into main Jul 13, 2022
@aboedo aboedo deleted the release/5.2.1 branch July 13, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants