Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates the billing client version to use for unity IAP compatibility… #560

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jul 12, 2022

I was getting the following error while trying a Unity-IAP compatible build.
It looks like Unity IAP updated their billing client version. The update was done in [3.1.0] - 2021-04-15, according to this changelog

Duplicate class com.android.billingclient.BuildConfig found in modules 
billing-3.0.3-runtime.jar (:billing-3.0.3:) and 
com.android.billingclient.billing-3.0.2-runtime.jar (:com.android.billingclient.billing-3.0.2:)

@aboedo aboedo requested review from vegaro and a team July 12, 2022 21:01
@aboedo aboedo self-assigned this Jul 12, 2022
@aboedo
Copy link
Member Author

aboedo commented Jul 13, 2022

@vegaro can I get a review for this one?
I'd love to do a release for this one, then propagate to the hybrids so we can release Unity today

@aboedo aboedo merged commit d2e4e54 into main Jul 13, 2022
@aboedo aboedo deleted the fix/update_billing_client_unity_iap branch July 13, 2022 14:56
@vegaro
Copy link
Contributor

vegaro commented Jul 13, 2022

Weird you were getting that error because the unity iap version of purchases-android-unityiap version shouldn't be bringing the billing client automatically 🤔

@vegaro
Copy link
Contributor

vegaro commented Jul 15, 2022

#566 fixes the unintentional exposure of the billing client to consumers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants