-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF-99: Separate docs per version #504
Conversation
967a11c
to
a448e41
Compare
@vegaro I made a few updates here so that we can include an index.html file that automatically redirects you to the latest version of the docs, if you didn't specify a version, could you take a look at that bit too? |
</head> | ||
<body> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten about this file 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a new file tho 😂 I just created it today so it would redirect automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I had uploaded one to AWS so it would redirect to the https://sdk.revenuecat.com/android/docs/index.html
if accessing https://sdk.revenuecat.com/android/index.html
. But I think that's long time gone 😄
command: aws s3 sync ~/purchases-android/docs/5.1.0-SNAPSHOT s3://purchases-docs/android/5.1.0-SNAPSHOT --delete | ||
- run: | ||
name: Update index.html | ||
command: aws s3 cp ~/purchases-android/docs/index.html s3://purchases-docs/android/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move these two to fastlane one day. Not now
… string if present
@@ -176,7 +178,7 @@ platform :android do | |||
end | |||
|
|||
def increment_version_in(previous_version, new_version, path) | |||
sed_regex = 's/' + previous_version + '/' + new_version + '/' | |||
sed_regex = 's/' + previous_version + '/' + new_version + '/g' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should always have been doing /g
otherwise it only replaces the first instance in the file
updates the output directory for dokka to include the version number.
This is the low-tech implementation.
A high-tech implementation would be to use the Versioning plugin, but that might take a lot more effort to set up, so in the meantime, the idea is to manually update the docs in S3 for the first time, and use this to generate them in the correct subfolder until we get the high-tech implementation in place.
Fixes CF-99