Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 4.4.0 #375

Merged
merged 5 commits into from
Nov 8, 2021
Merged

Release: 4.4.0 #375

merged 5 commits into from
Nov 8, 2021

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Nov 5, 2021

  • Added support for Airship integration via setAirshipChannelID

@aboedo aboedo requested a review from a team November 5, 2021 21:08
@aboedo aboedo self-assigned this Nov 5, 2021
* Subscriber attribute associated with the Airship Channel ID
* Required for the RevenueCat Airship integration
*
* @param airshipChannelID null will delete the subscriber attribute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do any special handling for empty values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have it, although I'm now realizing that the docstring wouldn't lead you to expect it
https://docs.revenuecat.com/docs/subscriber-attributes#deleting-attributes
I'll update

Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️ just the one question!

@aboedo aboedo merged commit e719249 into main Nov 8, 2021
@aboedo aboedo deleted the release/4.4.0 branch November 8, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants