Update to Android Gradle plugin 7.0.2 and buildToolsVersion 3.0.3 #363
Conversation
| @@ -18,7 +18,6 @@ POM_DEVELOPER_NAME=RevenueCat, Inc. | |||
|
|
|||
| android.useAndroidX=true | |||
| android.enableJetifier=true | |||
| android.enableR8.libraries = false | |||
There was a problem hiding this comment.
are we sure we no longer need this? do you remember why we had it in the first place?
There was a problem hiding this comment.
So I looked into it, and found where I added it https://github.com/RevenueCat/purchases-android/pull/72/files
I think the reason I added it is to not use R8 and use ProGuard since people were still using ProGuard. That way we would get errors when trying to build release. Enabling/Disabling R8 has been deprecated since, so I think we can remove this line. It would actually not compile with this line on.
So I think if by default AS will use R8 now, we should just be using R8.
|
@beylmk what do you think? :) |
Shoot, sorry i missed this! thanks for following up, i agree :) 🚢 it |
|
yayyy updateeesss |
Updated to the latest stable version of the Android Gradle plugin 7.0.2 and the build tools version to 3.0.3
Changes introduced by AGP 7 are outlined here https://android-developers.googleblog.com/2020/12/announcing-android-gradle-plugin.html
One of the main changes is that now we require JDK 11. In order to install it, the best way is to use sdkman. Instructions on that are here https://github.com/RevenueCat/purchases-android/blob/e2e4df2db2612d015a41db710e2a2afccd396c19/CONTRIBUTING.md#environment-setup