Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @Throws to getPackage #333

Merged

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Jun 14, 2021

addresses #332

The method getPackage could throw NoSuchElementException, but this behavior wasn't documented.
I added the @Throws annotation.

@aboedo aboedo self-assigned this Jun 14, 2021
@aboedo aboedo requested a review from a team June 14, 2021 21:30
Copy link
Contributor

@beylmk beylmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboedo aboedo merged commit 8e6c6db into develop Jun 28, 2021
@aboedo aboedo deleted the fix/crash_when_accessing_package_with_unknown_identifier branch June 28, 2021 15:00
@aboedo aboedo mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants