-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Implements Variables V2 #2099
Merged
Merged
Changes from 1 commit
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
a0b0911
Fixes compilation of IconComponentView.
JayShortway fbb2cb6
ColorInfo.Alias has a ColorAlias value now.
JayShortway 6357b73
Adds ColorStyles and a way to look them up.
JayShortway c0c801a
Adds UiConfig to StyleFactory and uses it to build StackComponentStyle.
JayShortway 3dd6bf8
Adds PresentedStackPartialTests and a fix to ColorStyle.
JayShortway 9946cc8
Adds ColorStyleTests
JayShortway ee91fd8
Merge branch 'main' into pw2-colorstyles
JayShortway d3e81c2
Updates documentation for a function.
JayShortway b148227
Renames a parameter.
JayShortway ab6a491
Fixes a compilation error.
JayShortway 044b221
Fixes test compilation.
JayShortway 8aeedbb
Adds ColorStyles to IconComponentStyle.
JayShortway ba778c0
Adds ColorStyles to IconComponentStyle.Background.
JayShortway 0b36305
Adds PresentedIconPartialTests.
JayShortway fe11b77
Merge branch 'main' into pw2-colorstyles-icon
JayShortway f21353d
ImageComponentStyle.overlay is a ColorStyles now.
JayShortway 240f508
Adds PresentedImagePartialTests.
JayShortway 8e814c9
Changes ColorScheme properties to ColorStyles in TextComponentStyle.
JayShortway a733f8b
Adds more LocalizedTextPartialTests.
JayShortway 89c5286
Introduces BorderStyles and adds it to StackComponentStyle.
JayShortway 0b25b3b
Adds BorderStyles to IconComponentStyle.Background.
JayShortway 7be4c38
Adds BorderStyles to ImageComponentStyle.
JayShortway 7ab352b
Introduces ShadowStyles and adds it to StackComponentStyle.
JayShortway a508cf5
Adds ShadowStyles to IconComponentStyle.Background.
JayShortway da30ef7
Adds ShadowStyles to ImageComponentStyle.
JayShortway 56e6b80
Adds BackgroundStyles and uses it for the main paywall.
JayShortway a7f46a8
Removes a bunch of functions that are not needed anymore.
JayShortway 8b20983
Merge branch 'main' into pw2-colorstyles-icon
JayShortway 27dd90f
Merge branch 'pw2-colorstyles-icon' into pw2-colorstyles-image
JayShortway 199816c
Merge branch 'pw2-colorstyles-image' into pw2-colorstyles-text
JayShortway 5300158
Merge branch 'pw2-colorstyles-text' into pw2-colorstyles-border
JayShortway 967b4f0
Merge branch 'pw2-colorstyles-border' into pw2-colorstyles-shadow
JayShortway 5891761
Merge branch 'pw2-colorstyles-shadow' into pw2-colorstyles-background
JayShortway e9a081f
Merge branch 'pw2-colorstyles-background' into pw2-color-alias-cleanup
JayShortway b5d90c1
Adds getResourceIdentifier() to ResourceProvider.
JayShortway 44d9af5
Merge branch 'main' into pw2-colorstyles-background
JayShortway 11eb74a
Re-reverts an unintended change.
JayShortway 3ce1c66
Fixes a test.
JayShortway ae87952
Merge branch 'main' into pw2-colorstyles-background
JayShortway 0ee2a8c
Merge branch 'pw2-colorstyles-background' into pw2-color-alias-cleanup
JayShortway 24d01d6
Merge branch 'pw2-color-alias-cleanup' into pw2-fonts-uiconfig
JayShortway 70cf708
Adds FontSpec.
JayShortway 2388bd8
Adds fontAliases parameter to StyleFactory.
JayShortway 36c3352
Adds fontAliases parameter to StyleFactory.
JayShortway 926775f
StyleFactory resolves FontSpecs.
JayShortway 841357e
Merge branch 'main' into pw2-fonts-uiconfig
JayShortway 31a43ad
TextComponent.fontName is a FontAlias now.
JayShortway 4ac6a5f
Adds FontSpec to TextComponentStyle and LocalizedTextPartial.
JayShortway ad309de
Adds more tests to StyleFactoryTests.
JayShortway fc6cbf3
Deletes SystemFontFamily.
JayShortway d5791da
Fixes LocalizedTextPartialTests.
JayShortway 6b31f04
Adds some LocalizedTextPartialTests.
JayShortway 79e61f6
Renames FontSpec.Device to FontSpec.System.
JayShortway 5874fc0
Adds some PaywallComponentDataValidationTests.
JayShortway 1868c25
Merge branch 'main' into pw2-fonts-uiconfig
JayShortway 9b7cb53
Fixes FontFamily not getting applied in the Markdown composable.
JayShortway 6dc16a1
Adds custom font paywall to PaywallsTester.
JayShortway 4779152
Removes passing the MockResourceProvider by default. Resolves a TODO.
JayShortway 6c020e6
Adds a Google Font paywall to PaywallsTester.
JayShortway 314b364
Merge branch 'main' into pw2-fonts-uiconfig
JayShortway 1ba3c5b
Fixes compilation after merge.
JayShortway 9a0ce39
Adds localizedPricePerDay() and localizedPricePerYear() to VariableDa…
JayShortway 39566ae
Adds a new PaywallValidationError.
JayShortway 488bf38
Adds StyleFactory and UiConfig convenience constructors for tests.
JayShortway aa7071d
Adds pricePerPeriod extensions.
JayShortway b87e977
Uses the new UiConfig and StyleFactory test helpers.
JayShortway 54089c1
Adds ComposeLocale.toJavaLocale().
JayShortway bb56c91
Adds variableLocalizationKeysForEnUs() to PreviewHelpers.kt.
JayShortway 64dc407
Adds Period.valueInDays.
JayShortway 552c32f
Uses previewTextComponentStyle in more places.
JayShortway 2561714
Adds pricePerDay to StoreProduct.
JayShortway bf0fe56
TextComponentView processes variables with VariableProcessorV2.
JayShortway 7529ab7
Adds a failing TextComponentViewVariablesTests.
JayShortway 82f08dd
Fixes a few tests.
JayShortway 57f7af0
Fixes another test.
JayShortway d4059ae
Passes Date around.
JayShortway d57fe0b
Fixes the final test.
JayShortway f0dfde4
Adds V2 variables to TextComponentViewTests.
JayShortway fdf5019
Adds a bunch more test cases.
JayShortway c722cd4
Adds a bunch more test cases, some failing.
JayShortway faa6184
Fixes tests.
JayShortway d42258a
TextComponentView longer processes V1 variables.
JayShortway 6bd4cc9
Some cleanup.
JayShortway 96dbfdd
Adds some tests.
JayShortway dbb2ac3
Some optimizations.
JayShortway 89dbac0
Some cleanup.
JayShortway 4343164
Merge branch 'main' into pw2-variables-v2
JayShortway 307cbd5
Fixes previews.
JayShortway aba0a43
Adds StyleFactory and UiConfig convenience constructors for tests.
JayShortway 707955a
Adds variableLocalizations to TextComponentStyle, and uses previewTex…
JayShortway 6b027d5
Adds new price calculations needed for Variables V2.
JayShortway 31ba3f7
Merge branch 'pw2-variables-v2-2' into pw2-variables-v2-3
JayShortway 3c7056f
Attempts to fix broken previews.
JayShortway e295e57
Merge branch 'main' into pw2-variables-v2-3
JayShortway 8c32df8
Merge branch 'main' into pw2-variables-v2-3
JayShortway 523097d
Merge branch 'main' into pw2-variables-v2-3
JayShortway 8189144
Fixes compilation.
JayShortway eb7529a
Adds tests for a lifetime product.
JayShortway f0c0e39
Corrects the lifetime product's description.
JayShortway 6484ed8
Merge branch 'main' into pw2-variables-v2-3
JayShortway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TextComponentView processes variables with VariableProcessorV2.
- Loading branch information
commit bf0fe56263ca556f56496d9c1fd925e4b7cc00b6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking... Some of these errors might be "acceptable" to continue displaying the paywall... As in, as long as we have the current locale correctly, we could display. I'm wondering if in the case it's not the current locale that is missing, we should just log... It would certainly make it easier to miss bugs on localization though, so maybe it's better this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea you're right that we might loosen this up a little. Something we can fine tune later I think?