Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for fr translations #2019

Merged
merged 1 commit into from
Dec 31, 2024
Merged

improvements for fr translations #2019

merged 1 commit into from
Dec 31, 2024

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Dec 31, 2024

adds a couple of improvements for the fr translations. Equivalent to RevenueCat/purchases-ios#4624

@aboedo aboedo added the pr:fix A bug fix label Dec 31, 2024
@aboedo aboedo requested a review from a team December 31, 2024 11:41
@aboedo aboedo self-assigned this Dec 31, 2024
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aboedo aboedo enabled auto-merge (squash) December 31, 2024 11:44
@aboedo aboedo merged commit 742b0d9 into main Dec 31, 2024
10 checks passed
@aboedo aboedo deleted the andy/improve_fr_translation branch December 31, 2024 12:09
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (564edb9) to head (632d62c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2019   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files         260      260           
  Lines        8516     8516           
  Branches     1226     1226           
=======================================
  Hits         6975     6975           
  Misses       1042     1042           
  Partials      499      499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero pushed a commit that referenced this pull request Jan 2, 2025
**This is an automatic release.**

## RevenueCat SDK
### 🐞 Bugfixes
* improvements for fr translations (#2019) via Andy Boedo (@aboedo)

### 🔄 Other Changes
* Feedback Surveys (#2010) via Cesar de la Vega (@vegaro)
* [Paywalls V2] Fixes previews (#2015) via JayShortway (@JayShortway)
* [Paywalls V2] Moves validation logic to the Loading phase (#2007) via
JayShortway (@JayShortway)
* Add Cancel subscriptions support (#2008) via Cesar de la Vega
(@vegaro)
* [Paywalls V2] Localizations are kept in a NonEmptyMap (#2001) via
JayShortway (@JayShortway)
* [Paywalls V2] `TextComponentState` handles locale changes (#2000) via
JayShortway (@JayShortway)
* [Paywalls V2] Some minor cleanup (#1994) via JayShortway
(@JayShortway)
* [Paywalls V2] `StackComponentView` handles overrides with
`StackComponentState` (#1993) via JayShortway (@JayShortway)
* Customer Center restores [CC-2] (#1999) via Cesar de la Vega (@vegaro)
* [Paywalls V2] Add more image component previews to test parent being
smaller than image size (#2004) via Toni Rico (@tonidero)
* [Paywalls V2] Add `PurchaseButtonComponent` support (#2002) via Toni
Rico (@tonidero)
* Build Customer Center from JSON (#1998) via Cesar de la Vega (@vegaro)
* Fix missing import after PR merge conflict (#1997) via Toni Rico
(@tonidero)
* [Paywalls V2] Add `StickyFooterComponentView` (#1991) via Toni Rico
(@tonidero)
* [Paywalls V2] `TextComponentView` handles overrides with
`TextComponentState` (#1989) via JayShortway (@JayShortway)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants