add original_purchase_date #164
Conversation
| @@ -193,6 +193,9 @@ internal fun String.sha1() = | |||
| } | |||
|
|
|||
| internal fun JSONObject.getNullableString(name: String): String? = this.getString(name).takeUnless { this.isNull(name) } | |||
| internal fun JSONObject.optNullableString(name: String): String? = this.optString(name)?.takeUnless { | |||
There was a problem hiding this comment.
I think optString returns "" if the JSON doesn't contain the name, which is very very annoying
There was a problem hiding this comment.
good catch. I got bit by looking at the search result
but not reading in the actual doc
Returns the value mapped by name if it exists, coercing it if necessary, or the empty string if no such mapping exists.
Fixing
There was a problem hiding this comment.
the method actually does work, though, because of the takeUnless, which checks if the object isNull. That check will return true if the key isn't found in the JSON https://developer.android.com/reference/org/json/JSONObject#isNull(java.lang.String)
There was a problem hiding this comment.
I added an extra test case to make sure (also tested manually)
There was a problem hiding this comment.
I see. optString will never return null though, so ?. should be . right?
|
@vegaro I removed the ?, now it looks almost like the other method 👍 |
Added parsing of
original_purchase_dateinsubscriberto purchaserInfo