Paywalls: fix template 5 title alignment
#1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't notice in our tests because of the large string, but it was vertically centered instead of left aligned like it should be (that's how it's designed in the dashboard and iOS).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 218 218
Lines 7260 7260
Branches 1011 1011
=======================================
Hits 6078 6078
Misses 788 788
Partials 394 394 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Jan 30, 2024
| @@ -242,6 +242,8 @@ private fun Title( | |||
| textAlign = TextAlign.Left, | |||
| text = state.selectedLocalization.title, | |||
| color = state.templateConfiguration.getCurrentColors().text1, | |||
| modifier = Modifier | |||
| .fillMaxWidth(), | |||
There was a problem hiding this comment.
I believe it should but just to check, this look good on landscape?
vegaro
pushed a commit
that referenced
this pull request
Feb 5, 2024
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: fix template 5 title alignment (#1585) via NachoSoto (@NachoSoto) * `Paywalls`: replace `TextAlign.Left` with `TextAlign.Start` to better support RTL (#1584) via NachoSoto (@NachoSoto) * Paywall views: Support updating options state after initial layout (#1582) via Toni Rico (@tonidero) * `Paywalls`: improve `PaywallData.configForLocale()` disambiguation (#1579) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `e6ba247` to `9c82c7a` (#1583) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `OfferingsFactory`: debug logs when creating `Offerings` (#1576) via NachoSoto (@NachoSoto) * `Paywalls`: log error when creating `PaywallState.Error` (#1574) via NachoSoto (@NachoSoto) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't notice in our tests because of the large string, but it was vertically centered instead of left aligned like it should be (that's how it's designed in the dashboard and iOS).