Paywalls: add Chinese from mainland China #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Dec 22, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 218 218
Lines 7196 7196
Branches 1007 1007
=======================================
Hits 6055 6055
Misses 750 750
Partials 391 391 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Dec 22, 2023
|
@RevenueCat/coresdk one thing I realized is that we don't have an android equivalent to this iOS key: https://github.com/RevenueCat/purchases-ios/blob/main/RevenueCatUI/Resources/zh-Hans.lproj/Localizable.strings#L5 do we not provide this behavior by default? |
|
And yeah I think we don't have that alert in Android. |
vegaro
pushed a commit
that referenced
this pull request
Dec 26, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: `PurchaseCancelledError` sends `onPurchaseCancelled` instead of an error (#1538) via NachoSoto (@NachoSoto) * Paywalls: add Chinese from mainland China (#1537) via Andy Boedo (@aboedo) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Chinese from mainland China.
Notes:
zh_CNandzh_SG. ChatGPT suggested adding those two as the equivalent. I added only one, under the assumption that zh_SG would automatically pick up zh_CN just like what happens in different variations of Spanish or English.