Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paywalls: improve Chinese localization #1529

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Dec 20, 2023

Android equivalent to RevenueCat/purchases-ios#3489

I noticed that we don't have a separate file for Chinese Simplified on Android? Is this intentional?

@aboedo aboedo requested review from greenietea and a team December 20, 2023 16:25
@aboedo aboedo self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b6c4ca) 84.14% compared to head (441a43e) 84.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files         218      218           
  Lines        7196     7196           
  Branches     1007     1007           
=======================================
  Hits         6055     6055           
  Misses        750      750           
  Partials      391      391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! As for why we don't have simplified chinese... I'm not sure... @NachoSoto ?

@NachoSoto
Copy link
Contributor

I automated the import of languages from iOS. Let me check.

@NachoSoto
Copy link
Contributor

NachoSoto commented Dec 20, 2023

I'm not familiar, would it be zh?
Screenshot 2023-12-20 at 10 18 51

@greenietea
Copy link
Contributor

greenietea commented Dec 21, 2023

I'm not familiar, would it be zh? Screenshot 2023-12-20 at 10 18 51

both traditional and simplified are represented as zh.

are we meant to also have another file named: ui/revenuecatui/src/main/res/values-zh-rHans/strings.xml where we keep the simplified version?

I was looking at this with the -Hans suffix: https://github.com/francisfeng/purchases-ios/blob/58623b2731cf1e9e0e156d16e3f20130b975de12/RevenueCatUI/Resources/zh-Hans.lproj/Localizable.strings

@aboedo
Copy link
Member Author

aboedo commented Dec 21, 2023

I can tackle adding it as a separate PR, thanks!

@aboedo aboedo merged commit 9a352bd into main Dec 21, 2023
2 checks passed
@aboedo aboedo deleted the andy/fix/chinese_localization branch December 21, 2023 22:32
vegaro pushed a commit that referenced this pull request Dec 22, 2023
**This is an automatic release.**

### RevenueCatUI
* Add `launchIfNeeded` with `offeringIdentifier` (#1533) via Cesar de la
Vega (@vegaro)
* Hide action bar from paywall activity (#1532) via Toni Rico
(@tonidero)
* Paywalls: improve Chinese localization (#1529) via Andy Boedo
(@aboedo)
### Other Changes
* Wait for tests to pass when deploying (#1521) via Cesar de la Vega
(@vegaro)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants