-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywalls: improve Chinese localization #1529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 218 218
Lines 7196 7196
Branches 1007 1007
=======================================
Hits 6055 6055
Misses 750 750
Partials 391 391 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! As for why we don't have simplified chinese... I'm not sure... @NachoSoto ?
I automated the import of languages from iOS. Let me check. |
both traditional and simplified are represented as zh. are we meant to also have another file named: I was looking at this with the |
I can tackle adding it as a separate PR, thanks! |
**This is an automatic release.** ### RevenueCatUI * Add `launchIfNeeded` with `offeringIdentifier` (#1533) via Cesar de la Vega (@vegaro) * Hide action bar from paywall activity (#1532) via Toni Rico (@tonidero) * Paywalls: improve Chinese localization (#1529) via Andy Boedo (@aboedo) ### Other Changes * Wait for tests to pass when deploying (#1521) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Android equivalent to RevenueCat/purchases-ios#3489
I noticed that we don't have a separate file for Chinese Simplified on Android? Is this intentional?