Generating new test snapshots for main
#5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed some strings and regressed others. I believe we're both aware of why and a path towards making this better. Are you ok with this @tonidero? |
tonidero
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Yeah, I see the only ones affected are templates 4 and 5, whose test data doesn't have an spanish locale, so the changes actually make sense. There are still some strings in spanish for the hardcoded strings in the footer, but we probably need to see how to inject the locale before getting those strings. Planning to take a look at this today. In the meantime, I think this looks good.
|
I think this can be closed in favor of #6 right @NachoSoto ? |
|
Yes thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by local user for main