feat(api): add offset and count parameters to API_GetGameList

[WedgeSparda]

Hi, in order to support pagination in any API client, I added a couple of params offset and count.

These are the same parameter used by getGamesListByDev function, but the API endpoint wasn't support them.

I added a test for these new parameters but despite working in reality, test is rising an error related to SQL_CALC_FOUND_ROWS not being supported.

API Docs PR is here

[wescopeland]

Overall I agree with this change. This is one of the few endpoints that at some point we should seriously consider introducing a breaking change into that forces users to paginate it.

[WedgeSparda]

@wescopeland I'm playing with Eloquent and I got this code, instead of using getGamesListByDev

$query = DB::table('GameData')
    ->where('ConsoleID', $consoleID);

if ($withAchievements) {
    $query->whereExists(function ($query) {
        $query
            ->from('Achievements')
            ->whereColumn('GameData.ID', 'Achievements.GameID');
    });
}

if ($offset > 0 && $count > 0) {
    $query
        ->offset($offset)
        ->limit($count);
}

$response = $query->get();

In order to check if the game has Achievements, I'm using the foreign key from Achievements table since I'm not sure if achievements_published field is reliable. In the development set of data that field is NULL for all games.

[wescopeland]

It's safe to assume achievements_published is reliable. I'll add something to my TODO list to ensure the seeder is spitting out sane data for that field.

[WedgeSparda]

@wescopeland So I took your advice and completely replaced the use of getGamesListByDev with Eloquent. Now the tests are passing correctly and the new params work as expected (I added a new test step to be sure about it).

Hope you like my code 😅

[WedgeSparda]

@wescopeland

All problems raised have beed fixed. Also added a new test when only count param is present.