Skip to content

Find and parse .action files as required #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ let Rosnodejs = {
rosNode = new RosNode(nodeName, rosMasterUri);

return new Promise((resolve, reject) => {
this.use(options.messages, options.services).then(() => {
this.use(options.messages, options.services, options.actions).then(() => {
_checkMasterHelper(resolve, 0);
});
})
Expand Down Expand Up @@ -165,15 +165,13 @@ let Rosnodejs = {

/** create message classes and services classes for all the given
* types before calling callback */
use(messages, services) {
use(messages, services, actions) {
const self = this;
return new Promise((resolve, reject) => {
self._useMessages(messages)
.then(() => {
return self._useServices(services);
}).then(() => {
resolve();
});
.then(() => { return self._useServices(services); })
.then(() => { return self._useActions(actions); })
.then(() => { resolve(); });
});
},

Expand All @@ -194,7 +192,7 @@ let Rosnodejs = {
});
},

/** create message classes for all the given types */
/** create service classes for all the given types */
_useServices(types) {
if (!types || types.length == 0) {
return Promise.resolve();
Expand All @@ -213,6 +211,23 @@ let Rosnodejs = {
});
},

/** create action classes for all the given types */
_useActions(types) {
if (!types || types.length == 0) {
return Promise.resolve();
}
var count = types.length;
return new Promise((resolve, reject) => {
types.forEach(function(type) {
messages.getAction(type, function() {
if (--count == 0) {
resolve();
}
});
});
});
},

/**
* @return {NodeHandle} for initialized node
*/
Expand Down
46 changes: 40 additions & 6 deletions utils/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ messages.getServiceResponse = function(messageType, callback) {
getMessageFromPackage(messageType, ["srv", "Response"], callback);
}

/** ensure the handlers for this action type (goal, result, and
* feedback) are in the registry, create them if they don't exist */
messages.getAction = function(messageType, callback) {
getMessageFromPackage(messageType, ["action", "Goal"], function() {
getMessageFromPackage(messageType, ["action", "Result"], function() {
getMessageFromPackage(messageType, ["action", "Feedback"], callback);
});
});
}

// ---------------------------------------------------------
// Registry

Expand All @@ -61,7 +71,11 @@ var registry = {};
'SetBool': classdef,
...
}
}
},
action: { Goal: ..,
Result: ..,
Feedback: ..
}
},
'packagename2': {..}
};
Expand Down Expand Up @@ -104,25 +118,26 @@ function getMessageFromRegistry(messageType, type) {
@param message is the message class definition
*/
function setMessageInRegistry(messageType, type, message) {

var packageName = getPackageNameFromMessageType(messageType);
var messageName = getMessageNameFromMessageType(messageType);

if (!registry[packageName]) {
registry[packageName] = { msg: {}, srv: {}};
registry[packageName] = { msg: {}, srv: {}, action: {}};
}

var kind = type[0]; // "msg" or "srv"
var kind = type[0]; // "msg" or "srv" or "action"
if (kind == "msg") {
// message
registry[packageName][kind][messageName] = message;

} else {
// service
// service or action
if (!registry[packageName][kind][messageName]) {
registry[packageName][kind][messageName] = {};
}

var serviceType = type[1]; // "Request" or "Response"
var serviceType = type[1]; // "Request" or "Response", or "Goal", "Result", "Feedback"
registry[packageName][kind][messageName][serviceType] = message;
}
}
Expand Down Expand Up @@ -324,16 +339,35 @@ function extractFields(content, details, type, callback) {

var lines = content.split('\n');

if (type[0] != "msg") {
if (type[0] == "srv") {
var divider = lines.indexOf("---");
if (type[1] == "Request") {
// request
lines = lines.slice(0, divider);
} else {
// response
lines = lines.slice(divider+1);
}
}

if (type[0] == "action") {
var divider = lines.indexOf("---");
if (type[1] == "Goal") {
// goal
lines = lines.slice(0, divider);
} else {
var afterFirst = lines.slice(divider+1);
var divider2 = afterFirst.indexOf("---");
if (type[1] == "Result") {
// result
lines = afterFirst.slice(0, divider2);
} else {
// feedback
lines = afterFirst.slice(divider2+1);
}
}
}

async.forEachSeries(lines, parseLine, function(error) {
if (error) {
callback(error);
Expand Down