Skip to content

Improved code for updating testRun #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2016
Merged

Improved code for updating testRun #41

merged 1 commit into from
Dec 22, 2016

Conversation

sfranchuk
Copy link

#add class TestRunUpdater.java
#deprecated method updateTestRun(int runId, TestRun testRun)
#created method updateTestRun(int runId, TestRunUpdater testRunUpdater)

Improved code for updating testRun
1f652f1 
#add class TestRunUpdater.java
#deprecated method `updateTestRun(int runId, TestRun testRun)`
#created method `updateTestRun(int runId, TestRunUpdater testRunUpdater)`
@sfranchuk sfranchuk mentioned this pull request Dec 22, 2016
Closed
vinceis1337
vinceis1337 approved these changes Dec 22, 2016
View reviewed changes
Copy link
Contributor

@vinceis1337 vinceis1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting these changes, however deprecation is not necessary for updateTestRun. I will update instructions to indicate that a TestRunUpdater object should be used instead of a TestRun object now.

@vinceis1337 vinceis1337 merged commit b96035a into RetailMeNot:master Dec 22, 2016
@sfranchuk sfranchuk deleted the feature/improved-testRun-updating branch January 23, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceis1337 vinceis1337 vinceis1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfranchuk @vinceis1337