Sorting implementation for Logs/Messages, Recordings and Notifications #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 6, 2018 09:18
…test db records to be able to test sorting properly, introduced integration tests
…tBy field is not date
…I can utilized, simplified naming, addressed a backwards compatibility inconsistency
This reverts commit fad30fd.
…d unit tests for Recordings
added 9 commits
July 10, 2018 18:28
…og to make it consistent
… assertions in NotificationEndpointTest to use assertEquals which makes troubleshooting easier. also added more integration tests in CallEndpointTest, as they weren't up to par to what we did for the rest Logs entities
… assertions in NotificationEndpointTest to use assertEquals which makes troubleshooting easier. also added more integration tests in CallEndpointTest, as they weren't up to par to what we did for the rest Logs entities
…Comm-Core into atsakiridis_FS-270
atsakiridis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Facilitate sorting for Logs/Messages and Recordings
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: