Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clients json converter does not return voice_application_sid #2657

Closed
otsakir opened this issue Nov 23, 2017 · 1 comment
Closed

Clients json converter does not return voice_application_sid #2657

otsakir opened this issue Nov 23, 2017 · 1 comment
Assignees
@otsakir
Labels
1. Bug 3. Duplicate REST API
Milestone
FES - Sprint 05

Comments

@otsakir
Copy link
Contributor

otsakir commented Nov 23, 2017

There is a bug in Clients endpoint while retrieving clients in JSON. The 'voice_application_sid' property is not present. It exists in xml version of the method though.

After doing some investigation it seems it was a bug introduced by writePushClientIdentity() writer:

https://github.com/RestComm/RestComm-Connect/blob/ea3b0ddc78f3c0b44b344d8f3f32aecfae9bc4cf/restcomm/restcomm.http/src/main/java/org/restcomm/connect/http/converter/AbstractConverter.java#L461-L461
@otsakir otsakir added this to the FES - Sprint 05 milestone Nov 23, 2017
@otsakir otsakir self-assigned this Nov 23, 2017
otsakir added a commit that referenced this issue Nov 23, 2017
@otsakir
Fixes typo in ClientConverter
92328c2 
Fixes #2657
@otsakir otsakir mentioned this issue Nov 23, 2017
Merged
@otsakir
Copy link
Contributor Author

otsakir commented Nov 23, 2017

this is a duplicate of #2653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsakir otsakir

Labels
1. Bug 3. Duplicate REST API
Projects
None yet
Milestone
FES - Sprint 05
Development

No branches or pull requests
2 participants
@ammendonca @otsakir