Update hyperlink tooltips with optional additional data #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nytra
requested changes
Jan 15, 2025
|
Hmmm, which configuration did you test? When only the hyperlink is present, showing reason and url is (currently) intentional |
|
I thought with ShowExtendedTooltipForHyperlinks set to false it would just show the link like the old behavior |
|
Hmmm, it used to just show the reason. I guess we could have the attempts to open a hyperlink and the reason? Most items don't have super useful reasons 🤔 |
Nytra
approved these changes
Jan 16, 2025
|
Btw I approved this |
|
Was still thinking about what to show, but I guess it's fine anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always displays the reason and url when only the hyperlink label is present.
Optionally (based on setting) adds the reason and url to other labels.