fix(modals): tie body-scroll lock to open state#109
Merged
Conversation
Modals that called useLockScroll() unconditionally would stack a redundant lock when nested inside another locked modal (notably WalletBackupDialog inside WalletUnlocked), and the cleanup race on unmount left body overflow stuck on "hidden" — scrolling stayed disabled after the wallet closed. Pass the open flag to every useLockScroll caller so the lock lifecycle tracks visible state instead of mount state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useLockScroll()unconditionally were stacking a redundant body-scroll lock when nested inside another locked modal. The worst case:WalletBackupDialogis mounted unconditionally insideWalletUnlockedand was locking scroll the whole time the wallet was open.body.style.overflowstuck on"hidden"— scrolling stayed disabled after the wallet (or onboarding overlay, etc.) closed.useLockScrollcaller so its lock lifecycle is tied to visible state, not mount state.Test plan
tsc --noEmitcleanbiome checkclean on touched files