Conversation
Collaborator
|
See workflowhub-eu/about#46 re: |
kinow
reviewed
Mar 23, 2023
Relates to ResearchObject/ro-crate-validator-py#4 git link for now as awaiting pypi permission for new release of rocrateValidator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress that adds ShEx validation of Workflow Run crates.
The initial checks on the RO-Crate are from https://github.com/ResearchObject/ro-crate-validator-py but may not be always appropriate. E.g. above it should skip the Scripts-check when it is a process crate profile being tested.
Note that so far only process run profile is complete. I've taken the stand that SHOULDs are required by the validation, as breaking a should is something done knowingly. However this may not be appropriate for checking the inherted profiles.
The remaining workflow/provenance profiles are not finished, as I think I need to add a second
ComputationalWorkflowbioschemas profile that is currently just implied.