conformsTo profile applies to root dataset, not metadata file #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stain
added a commit
that referenced
this pull request
Jan 16, 2023
Example: https://by-covid.github.io/baseline-use-case-synthetic-crate/ro-crate-preview.html#vaccines_effectiveness_common_data_model_specification/data/metadata/attributes.csv ```json { "@id": "attributes.csv", "@type": "File", "encodingFormat": ["text/csv", {"@id": "https://www.nationalarchives.gov.uk/PRONOM/x-fmt/18"}], "conformsTo": {"@id": "https://docs.ropensci.org/dataspice/#create-spice"} }, { "@id": "https://docs.ropensci.org/dataspice/#create-spice", "@type": "CreativeWork", "name": "dataspice CSV profile" } ``` adds note to explain conformsTo used on ro-crate-metadata.json and root dataset for profiles This assumes #229
simleo
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
I've changed (4b4f5d9) the profile crate retrieval section to use Workflow RO-Crate for all examples. This way, since Workflow RO-Crate has a profile crate, readers can actually try following the instructions and check that they get JSON-LD when requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To indicate RO-Crate following a particular profile, then move so "conformsTo" applied to "./" as suggested in #153 (comment) (and agreed in calls 2022-09-08 and 2022-01-27) rather than on
ro-crate-metadata.jsonentity.This means
conformsToon thero-crate-metadata.jsonis only for RO-Crate spec itself (considering it from a JSON/JSON-LD perspective) while profiles about the content/shapes of a class of crates are appliec usingconformsToon the root dataset (./)This also makes it easier to link to other RO-Crates as a
Datasetand saying they follow a particular profile -- however you would also need to add asubjectOfto link to theirro-crate-metadata.jsonin order to indicate it is an RO-Crate - so still not ideal.(also there is still no way to indicate RO-Crate-ness on a nested
Datasetwhich has adistributionto a Zip/tarDataDownloadaccording to https://www.researchobject.org/ro-crate/1.1/data-entities.html#directories-on-the-web-dataset-distributions.)See also ResearchObject/workflow-run-crate#40 which applies this on the Workflow Run Crate profiles.
This fixes #126