Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RO-Crate Profile section #154

Merged
merged 13 commits into from
Jul 8, 2021
Merged

RO-Crate Profile section #154

merged 13 commits into from
Jul 8, 2021

Conversation

stain
Copy link
Contributor

@stain stain commented May 26, 2021

See issue #153.

This adds a section to explain:

It does not (yet) detail the suggestions on how to formally specify an RO-Crate profile as a new or adapted expression language.

This proposal have multiple sections we may not want to all include:

Now I added all these sections mainly for discussion – I am not convinced we want all of them! And perhaps some should move to data entity section on encoding or at least be linked to from there. XML is a tricky one because there are many declared subformats of XML but even more undeclared ones.

I added sdConformsTo in ro-terms as I realised https://www.researchobject.org/ro-crate/1.1/workflows.html#complying-with-bioschemas-computational-workflow-profile had then wrong use of conformsTo (the Knime file content does not conform!) - this could however be simplified by just lifting those profiles up to also be conformsTo on the ro-crate-metadata.json

@stain
Copy link
Contributor Author

stain commented Jun 10, 2021

See also schemaorg/schemaorg#2887 on adding structuredData (this metadata object) and schemaorg/schemaorg#1516 on adding conformsTo to schema.org

Now there is either just a website, or a Profile Crate
@stain
Copy link
Contributor Author

stain commented Jun 20, 2021

Following profile taskforce meeting 2021-06-18 it was decided to go for a simpler approach of:

  1. RO-Crate profiles are indicated by expanding conformsTo on ro-crate-metadata.json
  2. The profile indicated by conformsTo should be a WebPage that gives human readable information
  3. The profile MAY optionally also resolve to another RO-Crate, a Profile Crate
  4. The Profile Crate will have hasPart whatever schemas, documentation, software are relevant to this profile (but must still have a human-readable description)
  5. The Profile Crate is resolved either by Content Negotiation or by adding ./ro-crate-metadata.json to URL.

I have simplified the draft to reflect the above. I have also changed how profile languages are expressed: rather than a nested conformsTo (which may be confusing here), I used encodingFormat URIs as we already suggest for other entities.

@stain stain changed the title Initial text for RO-Crate Profile section RO-Crate Profile section Jun 20, 2021
@stain
Copy link
Contributor Author

stain commented Jun 20, 2021

I also added a suggestion on how to indicate extension vocabularies and JSON-LD contexts.

Here I used http://schema.org/DefinedTermSet and http://schema.org/DefinedTerm which seems quite appropriate - perhaps we should also use those instead of Thing in https://www.researchobject.org/ro-crate/1.1/appendix/jsonld.html#extending-ro-crate ?

@stain
Copy link
Contributor Author

stain commented Jun 24, 2021

I tried realizing this as an example from the Workflow RO-Crate profile:

https://about.workflowhub.eu/Workflow-RO-Crate/ro-crate-preview.html

Notice how this was retrofitted to the old URL https://about.workflowhub.eu/Workflow-RO-Crate/ without change – ideally this should of course also be versioned and so on.

Example shows most of the features, and adds a list of licenses that Workflow Hub expects.

@stain
Copy link
Contributor Author

stain commented Jul 8, 2021

Agreed (somewhat) in RO-Crate community call 2021-07-08 to merge as-is for 1.2-DRAFT, but also:

  • Add diagram
  • Explore further semantics, inheritance, templates and MUST/SHOULD/MAY requirements

@stain stain merged commit b65318f into master Jul 8, 2021
@stain stain deleted the profiles branch July 8, 2021 10:30
@stain stain restored the profiles branch July 8, 2021 10:30
@marc-portier
Copy link
Contributor

@stain - with some minor suggestions (scrible? expectations? format?) I could throw up a first draft for that diagram ...

@stain stain deleted the profiles branch July 9, 2021 14:16
@stain
Copy link
Contributor Author

stain commented Jul 9, 2021

Thanks, Marc!

For the diagram, perhaps something like:

Example RO-Crate —conformsTo→ PID —redirect→ WFRun ProfileCrate —hasPart→ 
    - profile-for-describo.json —encodingFormat→ DescriboJSONProfile
    - ComputationalWorkflow
    - licenses/

but using some icons. Also not sure if the ProfileCrate itself should say it is a profile crate (conformsTo: https://www.researchobject.org/ro-crate/1.2-DRAFT/profiles.html or so?) or if that becomes a bit too much turtles all the way – at least explanation wise!

See https://about.workflowhub.eu/Workflow-RO-Crate/ro-crate-preview.html and https://about.workflowhub.eu/Workflow-RO-Crate/example/ as example.

stain added a commit that referenced this pull request Jan 20, 2022
This fixes issue #185

TODO: Resolve sdConformsto from #154 to align with
schemaorg/schemaorg#1516
schemaorg/schemaorg#2887

Adding a nested structuredData contextual entity here will get
excessively verbose (particularly on the FormalParameter which is
already a #nonDownloadable contextual entity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants