Skip to content

Conversation

@michaelcanova
Copy link
Contributor

@michaelcanova michaelcanova commented Oct 17, 2025

Issue:
Funds didn't sort by open/close, nor were there any more sorting options available. This PR fixes these issues and allows 4 different types of sorting:

Best(default) - sorts by open and close, and inside sorts by when it was created
Top - Sorts by the most amount of upvotes
Applicants - Sorts by the most applicants
Raised - Sorts by the amount of funding requested/earned,

This is part 4/5 of the Fund Page Sorting Project.
ResearchHub/issues#626

RFP:
image

Proposals:
image

For Previously Funded we decided to not show the dropdown at all and just defualt to the "Best" sorting.
image

@michaelcanova michaelcanova requested a review from a team as a code owner October 17, 2025 00:00
@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Oct 28, 2025 10:00pm

@yattias
Copy link
Contributor

yattias commented Oct 17, 2025

@michaelcanova functionality is good for the most part. I like that it works nicely in mobile too.

Some product feedback:

  1. When filtering, let's show loading skeleton (just like we do now when switching between tabs). Should not be lots of code, I'd say be careful of the loading trigger.

  2. "Raised" doesn't make sense in the context of "RFPs". should be "Amount" (maybe just label change). I think it does sort by amount but double check

image

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants