Updated Tip Supported Modules #440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 14, 2025 13:08
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
yattias
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Code looks good but make sure this works for all content types on staging.
on prod, have @TylerDiorio verify any post (ideally proposal) to make sure it looks good
| onClose={() => setIsModalOpen(false)} | ||
| contentId={documentId} | ||
| feedContentType="PAPER" | ||
| feedContentType={contentType === 'paper' ? 'PAPER' : 'POST'} |
There was a problem hiding this comment.
Are there other types backend can accept here or just paper vs post?
There was a problem hiding this comment.
How our backend currently processes it is just paper, "rhcommentmodel" or "researchhubpost". I can update these if you'd like me to to be a bit more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Tips were only working on Papers and Comments, but questions, preprints etc were not showing the tips. A fix both here on the front end and on the backend properly set the status and returned the correct data formatting for all non-paper and comment types.