Progress updates revamp #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate real % of updates from start date of fundraise onward (no ending yet) Tooltip to tell users about 100 RSC incentive Multiple updates per month
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 3f31159.
yattias
reviewed
Jul 25, 2025
- Extracted the complex start date calculation logic from `ProgressUpdates.tsx` into a new, reusable helper function `getTimelineStartDate` in `FundUtils.ts`. Improve maintainability and ensures that both the visual timeline (`ProgressUpdates`) and the rate calculation (`calculateUpdateRate`) use the exact same source of truth for their start date. - **New:** Created `getTimelineStartDate` in `FundUtils.ts` to handle all fallback and normalization logic for determining the timeline's start. - **Update:** Refactored `ProgressUpdates.tsx` to remove its local date logic and call the new centralized helper function. - **Update:** Refactored `calculateUpdateRate` to also use `getTimelineStartDate`, ensuring perfect consistency between the UI and the data calculation.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Overhaul progress updates timeline