Skip to content

Conversation

@dominikusbrian
Copy link

Passing down fix for award bounty modal not working explained here
ResearchHub/issues#319

Loom video link:
https://www.loom.com/share/d503bcf510954c6f9634902db28d2312?sid=ab60e456-d2fc-4c68-9da6-a9e96df466e9

…wards. Tested with a variety of cases involving comments that were previously awarded bounties and have direct tips.
@dominikusbrian dominikusbrian requested a review from yattias June 28, 2025 15:38
@vercel
Copy link

vercel bot commented Jun 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2025 3:55am

@dominikusbrian
Copy link
Author

The SonarCloud Quality Gate failed here. Not sure what to do with it.
It cited maintanability rating is B instead of >A. Looking into the report, in highlight the nested structure of the code, which already there with the previous version of the file as well :
image

Any suggestion what the action needed here? Should we find a simpler restructuring for the whole suggested items, which means changing the overall structure of previous version of the code too?

Or these can be safely ignore ? Or maybe which part of it require extra care ?
Looking for guidance here.

@gzurowski
Copy link
Member

The SonarCloud Quality Gate failed here. Not sure what to do with it. It cited maintanability rating is B instead of >A. Looking into the report, in highlight the nested structure of the code, which already there with the previous version of the file as well : image

Any suggestion what the action needed here? Should we find a simpler restructuring for the whole suggested items, which means changing the overall structure of previous version of the code too?

Or these can be safely ignore ? Or maybe which part of it require extra care ? Looking for guidance here.

I have just enabled the Sonar integration for the web project last week. At this point, I would mostly use it as a guide, but we don't have it customized sufficiently to adhere to the ratings. Additionally, modifying existing code to meet a specific rating score is outside the scope of your changes.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants