UI Fixes #754
UI Fixes #754
Conversation
|
Could you add some screenshots for the fixes please. Thank you |
|
No blocker besides the Disucssions portion. Per our conversation, let's take that part out and land the bug fixes first. thank you! |
|
Implemented requested changes and added visual summary. |
| @@ -119,6 +119,7 @@ function InlineCommentThreadCard({ | |||
| paperDraftStore, | |||
| commentThreadID: threadID, | |||
| }); | |||
| inlineCommentStore.set("animatedTextCommentID")(threadID); | |||
There was a problem hiding this comment.
i thought this was deprecated as of last week. Could you check and remove? Other than that all good. Thanks for the discussions style fix. I totally missed it
There was a problem hiding this comment.
I don't have context for this. Other than rebasing off master, I can't resolve this.
There was a problem hiding this comment.
what do you mean? you added this line. Just remove the line?
There was a problem hiding this comment.
I think we need to adjust our communication. When you say "I thought this was deprecated as of last week. Could you check and remove?" I'm assuming that you aren't certain and want me to investigate and figure it out.
I'm telling you that I don't have context and don't have a place to start, and suggesting you would be the best person.
If you tell me, "This is deprecated. Please remove" then I can do that.
| @@ -119,6 +119,7 @@ function InlineCommentThreadCard({ | |||
| paperDraftStore, | |||
| commentThreadID: threadID, | |||
| }); | |||
| inlineCommentStore.set("animatedTextCommentID")(threadID); | |||
There was a problem hiding this comment.
what do you mean? you added this line. Just remove the line?
…h new inline comments
Feature
Resize Bug Before
https://user-images.githubusercontent.com/36824145/115797203-33827700-a388-11eb-9fea-76f7f43f04de.mp4
Resize Bug Fix After
https://user-images.githubusercontent.com/36824145/115797218-42692980-a388-11eb-9d45-34bd4580213e.mp4
Fixed Table of Content Behavior
https://user-images.githubusercontent.com/36824145/115797239-501eaf00-a388-11eb-958f-ed6a0b15808c.mp4