Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsOne work trial - Hubs Page Redesign (Frontend) #626

Merged
merged 87 commits into from
Oct 7, 2020
Merged

AsOne work trial - Hubs Page Redesign (Frontend) #626

merged 87 commits into from
Oct 7, 2020

Conversation

thomas-vu
Copy link

Redesigned the Hubs page.

ebiederstadt and others added 30 commits September 14, 2020 16:28
@ebiederstadt
Hubs: Reworks how hubs are displayed on the hubs page
e068bb1 
- The hub is displayed with an image, description, and a button that allows for subscribing to the hub.
- Adds mocks for displaying the number of papers, discussions, and subcribers in the hub
@sm-hwang
styling for hubcard, not done
ac66738
@sm-hwang
changed hubcard into component, enlarges on hover
a2cc12d
@sm-hwang
commiting hubcard
8e5e7ec
trying to display categories on frontend
68ba775
merged card changes with sidebar
913113f
@ebiederstadt
Hubs: Allows the user to set the description flag when suggesting a n…
a9c764d 
…ew hub.
added grouping hubs by category
58f376c
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
6ab0793 
…researchhub-web into AsOne/hubs_redesign
@sm-hwang
no longer filler for subscriber count, distinguish between sub/unsub
4c8330a
@sm-hwang
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
6f2bea1 
…researchhub-web into AsOne/hubs_redesign
added categories to the sidebar
f9c22fd
fixed merge conflict, refactored subscribe button
6a27690
added flexible grid for hubcards
300434a
resized hubcards and removed unused code
f2fdafd
@ebiederstadt
Suggest a Hub: Allows users to choose an image while creating a new hub.
ee1fa8f
@ebiederstadt
Suggest a Hub: Allows users to set categories for newly created hubs
4e46fb2
@ebiederstadt
Suggest a a hub: Fixes issues around categories
33a3716
@ebiederstadt
Hubs: Prevents hub categories from being overwritten when closing the…
5e62c52 
… AddHubModal
@ebiederstadt
Hubs: Touchups
0b7f941 
- Uses lazy loading in the hubs page to improve performance.
- Fixes a few typos I noticed.
- Renames renderColumn -> renderCategories and renderList to renderHubs.
@ebiederstadt
Hubs: Prevents Users from uploading a hub without first selecting a c…
f51cfd3 
…ategory
fixed anchor offset and encoding bug, made hub images non-draggable
08ec903
@sm-hwang
no more filler for paper/discussion counts for hubcard
a70c4b2
@sm-hwang
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
855e3bf 
…researchhub-web into AsOne/hubs_redesign
@sm-hwang
added sub button functionality to hubcards
7475564
@sm-hwang
Doesn't embed button in <a> anymore
8f3a954
@ebiederstadt
Hubs: Fixes an issue where users would not be able to re-submit a req…
ceb8746 
…uest after they choose a hub category
@sm-hwang
logging in on hubpage will correctly indicate which hubs you're subsc…
6f4cf08 
…ribed to
@sm-hwang
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
812f71b 
…researchhub-web into AsOne/hubs_redesign
@ebiederstadt
Hubs: Sets a default image for hubs lacking an image
ed970a7
Thomas Vu and others added 28 commits September 29, 2020 18:35
updated look of hubcard edit button
76e8a40
@sm-hwang
character limit for hubname/description
ec4caf7
@sm-hwang
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
704f00a 
…researchhub-web into AsOne/hubs_redesign
@ebiederstadt
Edit Hubs: Only fetches hub categories when required
0792baf
@ebiederstadt
Merge branch 'AsOne/hubs_redesign' of github.com:ResearchHub/research…
61ceb2c 
…hub-web into AsOne/hubs_redesign
@sm-hwang
limit char count for edit modal
e492dba
now sorting categories and hubs alphabetically
0090a78
@sm-hwang
fixed add hub bug, edit hub doesn't show if not logged in
ee59961
@sm-hwang
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
247ea67 
…researchhub-web into AsOne/hubs_redesign
@sm-hwang
can update hub if name wasn't changed
031d00c
removed repeated calls to /api/hub
ada9f2c
Merge branch 'master' into AsOne/hubs_redesign
07741e8
@ebiederstadt
Edit Hubs: Changes hub page to react after editing a hub
90c1406
@ebiederstadt
Edit Hubs: Allows the user to press backspace when the length of the …
9aedb36 
…name or description is too long
fixed a subscription bug
a504841
@sm-hwang
one line to rule them all
072a8ab
@sm-hwang
subscription button reflects state, added key2 for categories list
d3c2d6e
fixed another subscription bug
8d8c308
@sm-hwang
ellipsis for hubname, word-break for description just in case
05ea027
fixed some subscription bugs
85ed705
Merge branch 'AsOne/hubs_redesign' of https://github.com/ResearchHub/…
0fdd815 
…researchhub-web into AsOne/hubs_redesign
Merge branch 'master' into AsOne/hubs_redesign
db303d4
@sm-hwang
subscribing updates hublist subscription status on hubpage
7a8057b
added overflow for create/edit hub modals on smaller screens
e56ba72
increased character limits for hub name/description
84b6da3
slightly adjusted add/edit hub modal height
7a5f516
@sm-hwang
fixed image/category edit bug
60dda76
@lightninglu10
small css tweak to overflows
3d300a4
@lightninglu10 lightninglu10 merged commit f3cd0a1 into master Oct 7, 2020
@lightninglu10 lightninglu10 deleted the AsOne/hubs_redesign branch October 7, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebiederstadt ebiederstadt ebiederstadt left review comments

@lightninglu10 lightninglu10 Awaiting requested review from lightninglu10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomas-vu @lightninglu10 @ebiederstadt @sm-hwang