Discussion tab and page #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| username = createUsername(discussion); | ||
| } | ||
|
|
||
| function renderComments(comments) { |
There was a problem hiding this comment.
can we use es6 functions?
|
Brief glance at the screenshots, the spacing between elements looks off. Like the upvote bubble needs some width to it, and needs to be 19px away from the avatar image. |
|
|
||
| const DiscussionTab = () => { | ||
| const threads = [{}]; | ||
| return <div>{renderThreads(threads)}</div>; |
There was a problem hiding this comment.
Should we have an infinite scroll here?
| }; | ||
|
|
||
| const MoreButton = () => { | ||
| // TODO: Fetch more comments |
There was a problem hiding this comment.
I think instead of having this it'd be easier to have infinite scrolling
lightninglu10
force-pushed
the
discussion
branch
from
53693f0 to
b784dfd
Compare
added 22 commits
October 3, 2019 11:37
lightninglu10
force-pushed
the
discussion
branch
from
bf9e1d5 to
0f3f968
Compare
thomas-vu
pushed a commit
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Closes #11
Notes
This is rebased on top of the text-editor branch (https://github.com/quantfive/researchhub-web/tree/text-editor) and master branch.
Testing
What code is changing?
DiscussionThreadCard.jsis rendering smaller componentsPaper/Tabs/DiscussionTab.jsincludes the url path for each threadPaperTabBar.jshas ui to include discussion thread count, and removes theprefetchattribute which is not required because prefetch happens by defaultconfig/api.jsconfig/themes/icons.jspages/paper/[paperId]/[tabName]/index.jsgets threads and thread count from paper propredux/paper.jstests/cypress/integration/utils/general.spec.jshas more unit tests for utilsScreenshots
To do