Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELN] Minor ELN fixes before demo #1002

Merged
merged 5 commits into from
Oct 22, 2021
Merged

[ELN] Minor ELN fixes before demo #1002

merged 5 commits into from
Oct 22, 2021

Conversation

yattias
Copy link
Contributor

@yattias yattias commented Oct 22, 2021

What?

  • Limiting placeholder to button in Settings & Members
  • Pass user.id instead of user.author_profile.id when changing permissions
  • Hide create note button until currentOrg is set to avoid exception thrown
  • Remove unnecessary useState from <ManageOrgModal>

@vercel
Copy link

vercel bot commented Oct 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/researchhub/researchhub-web-internal/5MiPNcQtYPR7GerQy7n86mZ2wHBP
✅ Preview: Failed

[Deployment for 19261e1 failed]

@yattias yattias requested a review from lightninglu10 October 22, 2021 19:50
@vercel vercel bot temporarily deployed to Preview October 22, 2021 19:58 Inactive
@yattias yattias merged commit 7e6096e into thomas/eln Oct 22, 2021
@lightninglu10 lightninglu10 deleted the kobe/eln/minor-fixes-before-demo branch October 22, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightninglu10 lightninglu10 lightninglu10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yattias @lightninglu10