fix: Trigger request fetch on tab change in invoice dashboard #330

rodrigopavezi · 2025-01-31T18:20:30Z

Problem

It was bugging pagination when changing tabs

Changes

trigger request fetch on tab change in invoice dashboard

Fixes #329

Summary by CodeRabbit

Version Update
- Bumped @requestnetwork/invoice-dashboard package version from 0.15.0 to 0.15.1
Bug Fixes
- Improved request data refresh mechanism when switching tabs to ensure accurate and up-to-date information is displayed

coderabbitai · 2025-01-31T18:20:38Z

Walkthrough

This pull request involves two primary changes: updating the version of the @requestnetwork/invoice-dashboard package from 0.15.0 to 0.15.1 and modifying the view-requests.svelte file to call the getRequests function within the changeTab function. The modification ensures that requests are automatically refreshed when switching tabs, addressing potential data staleness issues in the user interface.

Changes

File	Change Summary
`packages/invoice-dashboard/package.json`	Version updated from `0.15.0` to `0.15.1`
`packages/invoice-dashboard/src/lib/view-requests.svelte`	Added `getRequests()` call in `changeTab` function to refresh requests when changing tabs

Assessment against linked issues

Objective	Addressed	Explanation
Re-paginate on Paid/GetPaid tabs [#329]	✅
Re-paginate on sort [#329]	❓	Sorting functionality not explicitly shown in the diff

Possibly related PRs

fix: added payment check when invoice is paid #83: Changes related to isRequestPayed variable in the same file
chore: invoice-dashboard 0.6.1 #104: Version update for @requestnetwork/invoice-dashboard package
feat: pagination with caching #312: Modifications to request fetching in view-requests.svelte

Suggested reviewers

MantisClone
aimensahnoun
sstefdev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/invoice-dashboard/src/lib/view-requests.svelte (1)
Line range hint 577-579: Optimize duplicate getRequests calls in loadRequests.

The function calls getRequests twice: once after enabling/disabling decryption and again at the end of the function. This could lead to unnecessary API calls.

Consider removing the duplicate call:
  } finally {
    loading = false;
  }
- await getRequests(currentAccount, currentRequestNetwork);
- loading = false;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 022f883 and e83bb0a.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

packages/invoice-dashboard/package.json (1 hunks)
packages/invoice-dashboard/src/lib/view-requests.svelte (1 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/invoice-dashboard/package.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (1)

packages/invoice-dashboard/src/lib/view-requests.svelte (1)

439-441: LGTM! The change fixes the pagination issue.

The addition of getRequests call in the changeTab function ensures that data is properly refreshed when switching tabs, preventing stale data and pagination issues.

MantisClone

Looks good but wasn't this PR supposed to re-fetch on sort as well? It only seems to re-fetch on change tab.

rodrigopavezi · 2025-02-01T06:03:06Z

Looks good but wasn't this PR supposed to re-fetch on sort as well? It only seems to re-fetch on change tab.

I was planning to invalidate the query which would refetch entirely.

When I looked it further I noticed that SDK don't have a sort param and other filtering params to allow it to be properly implemented with current UI.

For instance, I can invalidate the query on sorting but SDK will always return in ascendent order.

fix: Trigger request fetch on tab change in invoice dashboard

e83bb0a

rodrigopavezi requested review from MantisClone, aimensahnoun and sstefdev January 31, 2025 18:20

rodrigopavezi self-assigned this Jan 31, 2025

coderabbitai bot reviewed Jan 31, 2025

View reviewed changes

MantisClone reviewed Feb 1, 2025

View reviewed changes

aimensahnoun approved these changes Feb 4, 2025

View reviewed changes

rodrigopavezi merged commit 4c9950f into main Feb 4, 2025
2 checks passed

rodrigopavezi deleted the fix/taps-with-new-pagination branch February 4, 2025 12:25

coderabbitai bot mentioned this pull request Feb 5, 2025

fix: Updated lit signature logic #331

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Trigger request fetch on tab change in invoice dashboard #330

fix: Trigger request fetch on tab change in invoice dashboard #330

Uh oh!

rodrigopavezi commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

MantisClone left a comment

Uh oh!

rodrigopavezi commented Feb 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: Trigger request fetch on tab change in invoice dashboard #330

fix: Trigger request fetch on tab change in invoice dashboard #330

Uh oh!

Conversation

rodrigopavezi commented Jan 31, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

MantisClone left a comment

Choose a reason for hiding this comment

Uh oh!

rodrigopavezi commented Feb 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rodrigopavezi commented Jan 31, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

rodrigopavezi commented Feb 1, 2025 •

edited

Loading