fix: enable decryption #254
Conversation
…ice dashboard and form - Refactored CipherProvider initialization to use reactive statements in both create-invoice-form and view-requests components. - Enhanced decryption toggle functionality with localStorage persistence in view-requests. - Improved type definitions for cipherProvider to include session signatures method. - Cleaned up code for better readability and maintainability.
|
Warning Rate limit exceeded@rodrigopavezi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces modifications to two key components: Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/create-invoice-form/src/lib/create-invoice-form.svelte (1)
118-118: EnsurecipherProvideris available before useBefore using
cipherProvider, confirm that it is defined to prevent runtime errors. Add checks wherecipherProvideris used, particularly in thesubmitFormfunction.For example, in
submitForm, you can guard the encrypted request creation:if (requestNetwork) { try { addToStatus(APP_STATUS.PERSISTING_TO_IPFS); let request; if (cipherProvider && formData.isEncrypted) { const payeeEncryptionParams = { /* ... */ }; const payerEncryptionParams = { /* ... */ }; + if (!cipherProvider) { + throw new Error("CipherProvider is not available."); + } request = await requestNetwork._createEncryptedRequest( { /* ... */ }, [payeeEncryptionParams, payerEncryptionParams], ); } else { request = await requestNetwork.createRequest({ /* ... */ }); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/create-invoice-form/src/lib/create-invoice-form.svelte(2 hunks)packages/invoice-dashboard/src/lib/view-requests.svelte(4 hunks)
🧰 Additional context used
📓 Learnings (1)
packages/create-invoice-form/src/lib/create-invoice-form.svelte (1)
Learnt from: MantisClone
PR: RequestNetwork/web-components#141
File: packages/create-invoice-form/src/lib/invoice/form.svelte:33-33
Timestamp: 2024-11-19T16:11:41.270Z
Learning: In the TypeScript file `packages/create-invoice-form/src/lib/invoice/form.svelte`, maintain the `any` type for the variables `currencyManager` and `network` without suggesting type replacements.
🔇 Additional comments (9)
packages/invoice-dashboard/src/lib/view-requests.svelte (7)
44-44: Import getEthersSigner to retrieve the Ethers signer
The addition of getEthersSigner from ../utils allows the component to obtain the Ethers signer, which is essential for signing operations within enableDecryption.
48-49: Import checkStatus for request status handling
Importing checkStatus from @requestnetwork/shared-utils/checkStatus ensures that the component can accurately determine and display the status of requests.
56-58: Update cipherProvider type with getSessionSignatures method
The cipherProvider now includes a getSessionSignatures method, which accepts a signer and walletAddress. This update enhances the typing and ensures that the method is recognized and type-checked by TypeScript.
60-60: Initialize sliderValueForDecryption from localStorage
Loading the decryption slider value from localStorage provides a persistent user experience, remembering the user's preference across sessions.
105-105: Ensure enableDecryption() is called after account change
Calling enableDecryption() when the account changes ensures that decryption settings are re-evaluated for the new account. This keeps the decryption state in sync with the current user.
135-140: Reactive assignment of cipherProvider
By making cipherProvider reactive, it updates whenever requestNetwork changes. This ensures that the latest cipherProvider instance is used throughout the component.
424-424: Reactive statement triggers enableDecryption() on slider change
Using $: to reactively call enableDecryption() when sliderValueForDecryption changes ensures that the decryption state updates immediately in response to user interaction.
packages/create-invoice-form/src/lib/create-invoice-form.svelte (2)
32-32: Initialize cipherProvider without immediate assignment
Setting cipherProvider to undefined initially and assigning it reactively allows for proper initialization once requestNetwork is available. This prevents potential issues with accessing cipherProvider before requestNetwork is ready.
118-119: Reactive assignment of cipherProvider
By reactively assigning cipherProvider with $: cipherProvider = requestNetwork?.getCipherProvider();, you ensure that cipherProvider updates whenever requestNetwork changes. This maintains consistency and prevents stale references.
Changes
refactor: update CipherProvider handling and decryption logic in invoice dashboard and form
Summary by CodeRabbit
New Features
Bug Fixes
Chores
create-invoice-formandinvoice-dashboard.